Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 6.6.1 #245

Closed

Conversation

doniwinata0309
Copy link

This PR to address this issue
#243

  • The spotless plugin need to update to avoid deprecated api.
  • check task is circular dependencies (failed after updating spotless)
  • Move dart-processor test to a single module, it need to add annotation processor classpath to access processor class.

Comment on lines +51 to +54
// def checkSubTask = project.tasks.findByName('check')
// if(checkSubTask) {
// tasks['check'].dependsOn checkSubTask
// }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to disable this because it is circular dependencies on henson-plugin:check task (detected on latest spotless version). What does checkSubtask doing in this case ? do you have any concern if we remove this ?

@doniwinata0309
Copy link
Author

#248 moved to this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant